Re: [PATCH v4 1/4] rebase: start implementing it as a builtin

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 22, 2018, 09:14 UTC
Message-ID: <CACsJy8D9mX4imSgQUdPgQEuj_CsuPwSUc9zLKjDTp4-q+Jnwkg@mail.gmail.com>
In-Reply-To: <20180708180104.17921-2-predatoramigo@gmail.com>

On Sun, Jul 8, 2018 at 8:03 PM Pratik Karki <predatoramigo@gmail.com> wrote:

Show 14 quoted lines

> +int cmd_rebase(int argc, const char **argv, const char *prefix)
> +{
> +       /*
> +        * NEEDSWORK: Once the builtin rebase has been tested enough
> +        * and git-legacy-rebase.sh is retired to contrib/, this preamble
> +        * can be removed.
> +        */
> +
> +       if (!use_builtin_rebase()) {
> +               const char *path = mkpath("%s/git-legacy-rebase",
> +                                         git_exec_path());
> +
> +               if (sane_execvp(path, (char **)argv) < 0)
> +                       die_errno("could not exec %s", path);

Please wrap all user visible strings in thi series in _().

> +               else
> +                       die("sane_execvp() returned???");

or if it's definitely a bug in the code, go with BUG()

-- 
Duy