Re: [PATCH] setup: do not create $X/gitdir unnecessarily when accessing git file $X

From: Duy Nguyen <pclouds@gmail.com>
Date: Nov 3, 2015, 05:48 UTC
Message-ID: <CACsJy8Csjgcv_L+TW9YPTs5V=T2XD+eqo1w1PO4jpfDoHLQKpQ@mail.gmail.com>
In-Reply-To: <xmqqtwp4dt17.fsf@gitster.mtv.corp.google.com>

(resend)

On Mon, Nov 2, 2015 at 9:51 PM, Junio C Hamano <gitster@pobox.com> wrote:

> Jeff King <peff@peff.net> writes:
>
>> [2] I suspect this code should use write_file_gently(). What happens if
>>     I have a read-only linked checkout?

I can't hide anything from you guys can I? :) My first attempt was move this update logic back to setup_..._gentle where it should belong, but it got complicated because read_file_gently was buried too deep and there was no easy way to get the information out.

I can try again, or..

Show 10 quoted lines

>
> Or you may not be the owner of the repository, you think you are
> doing a read-only operation, and you silently end up creating a file
> that cannot be written by the repository owner?
>
> Honestly, I think this whole "just in case the user moved without
> telling us, we sneakily fix things without telling the user" should
> just go away.  This is not the first incidence of a tool trying to
> be overly clever and pretend to know better than the end user biting
> us, is it?

The whole prune strategy is a bit messy trying to cover all cases while still keeping out of the user's way. Perhaps if we implement "git worktree mv", or even "worktree fixup" so the user can do it manually (back when the prune strategy commit was implemented, there was no git-worktree), then we don't need this magic any more.

So, which way to go?

-- 
Duy