Re: [PATCH v2 2/2] grep: stop looking at random places for .gitattributes
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Oct 11, 2012, 01:49 UTC
- Message-ID
- <CACsJy8CoedQBm4xyfhZX1mNTXpLMHxugygZUqOoZS8V5WVztGg@mail.gmail.com>
- In-Reply-To
- <50758477.3030304@viscovery.net>
On Wed, Oct 10, 2012 at 9:21 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
Show 12 quoted lines
>> + git commit -m new && >> + echo "Binary file HEAD:t matches" >expect && >> + git grep text HEAD -- t >actual && >> + test_cmp expect actual && >> + git reset HEAD^ >> +' > > And in yet another test, should > > git grep text HEAD:t > > /not/ respect the binary attribute?
Gray area. Is it ok to do that without documenting it (i.e. common sense)? I have something in mind that could do that, but it also makes "git grep text HEAD^{tree}" not respect attributes.
-- Duy