Re: git check-ignore ignores negated entries
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Sep 21, 2018, 16:13 UTC
- Message-ID
- <CACsJy8Cn-SyY6E8O3ttmr8k2vJ+8gGoN+NFmUSD71yiC1t552w@mail.gmail.com>
- In-Reply-To
- <CAB=bJ9Mjw2keJ3aspLWcreLBcB15Eq-WjtBO0XS8B=C3XJmx9A@mail.gmail.com>
On Thu, Sep 20, 2018 at 7:25 PM David Alphus <david.alphus@gmail.com> wrote:
Show 6 quoted lines
> In looking through check-ignore.c, it appears that we check that > last_exclude_matching() returns an exclude object. It should be noted > that we do not consider that exclude struct can be set with the > EXC_FLAG_NEGATIVE flag. This flag says that the final matching rule > should not be ignored. > check_ignore needs to consider this condition in order to work properly.
I haven't checked the code yet. But since you already did, patches are welcome ;-)
-- Duy