git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Fwd: Possible bug report: `git commit -ammend`

From
Duy Nguyen <pclouds@gmail.com>
Date
Nov 16, 2013, 03:28 UTC
Message-ID
<CACsJy8Ckb+qdQFcTHPcAiRy_08Nxtz5Uh_9R+NXz4yixWR9DUQ@mail.gmail.com>
In-Reply-To
<vpqsiux1wz3.fsf@anie.imag.fr>

On Fri, Nov 15, 2013 at 10:54 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 17 quoted lines
> rhys evans <rhys.evans@ft.com> writes:
>
>> I ran `git commit -ammend` on a repo where 1 out of 3 files changed
>> were staged for commit.
>>
>> I would've expected an error to be thrown due to the double typo but
>> instead it committed all 3 files with the message 'mend'.
>>
>> So it looks like it interpreted it as `git commit -a -m 'mend'`.
>
> Yes. This is a rather widespread convention (e.g. rm -fr == rm -r -f).
> Git does a special-case for -amend to avoid confusion:
>
>   $ git commit -amend
>   error: did you mean `--amend` (with two dashes ?)
>
> But it did not special-case the double-typo.

"-m" taking a string without a space or '=' increases the risk of this typo. If it does require '=' or ' ' after -m then -ammend is more likely to be rejected. Anybody know why we should support -mabc, besides convenient?

-- 
Duy
Previous: Matthieu MoyNext: Jeff King
Message 3 of 4 in “Fwd: Possible bug report: `git commit -ammend`”
  1. rhys evansNov 15, 2013
  2. Matthieu MoyNov 15, 2013
  3. Duy NguyenNov 16, 2013
  4. Jeff KingNov 16, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.