git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Auto Packing message twice?

From
Duy Nguyen <pclouds@gmail.com>
Date
Aug 30, 2014, 14:12 UTC
Message-ID
<CACsJy8Ch5WW2rF4vGrM2xyFqn2-1FgPw-kO_wLtBY8-+WqM-1g@mail.gmail.com>
In-Reply-To
<5401B56F.6000907@gmail.com>
On Sat, Aug 30, 2014 at 6:28 PM, Stefan Beller <stefanbeller@gmail.com> wrote:
Show 8 quoted lines
> Auto packing the repository in background for optimum performance.
> See "git help gc" for manual housekeeping.
> Auto packing the repository in background for optimum performance.
> See "git help gc" for manual housekeeping.
>
> Obviously it should only report once?
> The reporting is done from within function cmd_gc(...),
> which makes me wonder, if it also packs twice?

The problem is we print this message before checking if gc is running in background. Problem is we keep the lockafter forking/detaching because locking before forking means two processes holding the lock and I don't think there's a way to say "release the lock in parent process". And we can't print this message after detaching either because stdout is already closed then. But this definitely needs some improvement to avoid confusion.

-- 
Duy
Previous: Stefan BellerNext: Duy Nguyen
Message 2 of 3 in “Auto Packing message twice?”
  1. Stefan BellerAug 30, 2014
  2. Duy NguyenAug 30, 2014
  3. Duy NguyenAug 31, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.