git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] fsck improvements

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Nov 5, 2011, 03:18 UTC
Message-ID
<CACsJy8Ch0m5KQ--VWzsmyNq2R-uHsvSYofHP8L+qcvhRrqgoKQ@mail.gmail.com>
In-Reply-To
<7v1utnd8yf.fsf@alter.siamese.dyndns.org>
2011/11/5 Junio C Hamano <gitster@pobox.com>:
Show 7 quoted lines
> I am not sure what purpose patch 2 serves, though. When we find a checksum
> mismatch for an object in a packstream due to a single-bit error, we would
> still be able to salvage other objects in other parts of the pack as long
> as we have a good .idx file, and in such a case, wouldn't it be better if
> we attempted to find as many corrupt objects that we know we cannot
> recover as possible and tell the user about them, so that they can be
> skipped during the recovery process?

It's the inconsistency in that for(;;) loop. If we are going to salvage as many objects as we could, should we do "continue;" instead of "break;" when unpack_entry() or check_sha1_signature() fails?

-- 
Duy
Previous: Junio C HamanoNext: Junio C Hamano
Message 9 of 10 in “fsck improvements”
  1. 0/4 fsck improvementsNguyễn Thái Ngọc Duy, Nov 4, 2011
  2. 1/4 fsck: return error code when verify_pack() goes wrongNguyễn Thái Ngọc Duy, Nov 4, 2011
  3. 2/4 Stop verify_packfile() as soon as an error occursNguyễn Thái Ngọc Duy, Nov 4, 2011
  4. 3/4 fsck: avoid reading every object twiceNguyễn Thái Ngọc Duy, Nov 4, 2011
  5. 4/4 fsck: print progressNguyễn Thái Ngọc Duy, Nov 4, 2011
  6. Jeff KingNov 4, 2011
  7. Nguyen Thai Ngoc DuyNov 5, 2011
  8. Junio C HamanoNov 4, 2011
  9. Nguyen Thai Ngoc DuyNov 5, 2011
  10. Junio C HamanoNov 5, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.