git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-objects: convert to use parse_options()

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Feb 1, 2012, 14:30 UTC
Message-ID
<CACsJy8CZm96pVkavq_LvpX-MxdOtBw7XuwsQF61FJE8qk6ZZTg@mail.gmail.com>
In-Reply-To
<7v4nvb78om.fsf@alter.siamese.dyndns.org>

I'm going to address your comments soon (thanks by the way, making up summary line for each option from git-pack-objects.txt was painful) but since you like thought-provoking, check this comment out:

	/* Traditionally "pack-objects [options] base extra" failed;
	 * we would however want to take refs parameter that would
	 * have been given to upstream rev-list ourselves, which means
	 * we somehow want to say what the base name is.  So the
	 * syntax would be:
	 *
	 * pack-objects [options] base <refs...>
	 *
	 * in other words, we would treat the first non-option as the
	 * base_name and send everything else to the internal revision
	 * walker.
	 */

The last paragraph does not hold true anymore as far as I understand the code. IOW it drops everything in argv after base name. Looking back in history, the change was made by 8d1d8f8 (pack-objects: further work on internal rev-list logic. - 2006-09-06). Nothing is mentioned why it drops the remaining of argv. I suspect this is a regression and we should reinstate the behavior as the comment says.

-- 
Duy
Previous: Junio C HamanoNext: Nguyen Thai Ngoc Duy
Message 3 of 8 in “pack-objects: convert to use parse_options()”
  1. pack-objects: convert to use parse_options()Nguyễn Thái Ngọc Duy, Jan 31, 2012
  2. Junio C HamanoJan 31, 2012
  3. Nguyen Thai Ngoc DuyFeb 1, 2012
  4. Nguyen Thai Ngoc DuyFeb 1, 2012
  5. 1/3 pack-objects: do not accept "--index-version=version,"Nguyễn Thái Ngọc Duy, Feb 1, 2012
  6. 2/3 pack-objects: remove bogus commentNguyễn Thái Ngọc Duy, Feb 1, 2012
  7. 3/3 pack-objects: convert to use parse_options()Nguyễn Thái Ngọc Duy, Feb 1, 2012
  8. Junio C HamanoFeb 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.