git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] incorrect line numbers reported in git am

From
Duy Nguyen <pclouds@gmail.com>
Date
Oct 3, 2019, 06:17 UTC
Message-ID
<CACsJy8CZCdF-jPeYaAxzpnSbtxbRX42ScSJyYFCfmxZ0YBhZGg@mail.gmail.com>
In-Reply-To
<xmqqmueid508.fsf@gitster-ct.c.googlers.com>
On Thu, Oct 3, 2019 at 7:52 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 6 quoted lines
> > In fact, running `git am --show-current-patch` shows the whole mail, not
> > only the 'patch' file so users would have no reason to expect the line
> > numbers to refer to the 'patch' file.
>
> Yeah, show-current-patch was a misguided attempt to hide useful
> information from the users.

Not so much hiding as not having the information to present, at least not the easy way, since the mail is split at the beginning of git-am and never stored in $GIT_DIR. By the time this command is run, the mail is already gone. Someone could of course update git-am to keep a copy of the mail and improve this option.

-- 
Duy
Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 12 in “[BUG] incorrect line numbers reported in git am”
  1. Denton LiuOct 2, 2019
  2. Junio C HamanoOct 2, 2019
  3. Denton LiuOct 2, 2019
  4. Junio C HamanoOct 2, 2019
  5. Denton LiuOct 2, 2019
  6. Junio C HamanoOct 3, 2019
  7. Duy NguyenOct 3, 2019
  8. Junio C HamanoOct 3, 2019
  9. apply: tell user location of corrupted patch fileDenton Liu, Oct 4, 2019
  10. Junio C HamanoOct 5, 2019
  11. Junio C HamanoOct 5, 2019
  12. Junio C HamanoOct 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.