Re: git pull & git gc

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 19, 2015, 04:15 UTC
Message-ID: <CACsJy8CUbe4-f4rpieAKYzHb4rpKg8JW+uXB5yA4c1HFG6r4dg@mail.gmail.com>
In-Reply-To: <20150319012722.GA26867@peff.net>

On Thu, Mar 19, 2015 at 8:27 AM, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

> Keeping a file that says "I ran gc at time T, and there were still N
> objects left over" is probably the best bet. When the next "gc --auto"
> runs, if T is recent enough, subtract N from the estimated number of
> objects. I'm not sure of the right value for "recent enough" there,
> though. If it is too far back, you will not gc when you could. If it is
> too close, then you will end up running gc repeatedly, waiting for those
> objects to leave the expiration window.

And would not be hard to implement either. git-gc is already prepared to deal with stale gc.pid, which would stop git-gc for a day or so before it deletes gc.pid and starts anyway. All we need to do is check at the end of git-gc, if we know for sure the next 'gc --auto' is a waste, then leave gc.pid behind.

-- 
Duy