Re: [Proposal] git am --check

From: Duy Nguyen <pclouds@gmail.com>
Date: Jun 3, 2019, 09:35 UTC
Message-ID: <CACsJy8CUGfUwi15+ggOgRT4xotCkJVhGtCrjMa=4pdnDq25f4A@mail.gmail.com>
In-Reply-To: <CAP8UFD1W_tB34N-uAA85+QkHY6kmGWYYM47zceP3=5aTwxwvnQ@mail.gmail.com>

On Mon, Jun 3, 2019 at 4:29 PM Christian Couder <christian.couder@gmail.com> wrote:

Show 10 quoted lines

>
> On Sun, Jun 2, 2019 at 7:38 PM Drew DeVault <sir@cmpwn.com> wrote:
> >
> > This flag would behave similarly to git apply --check, or in other words
> > would exit with a nonzero status if the patch is not applicable without
> > actually applying the patch otherwise.
>
> `git am` uses the same code as `git apply` to apply patches, so there
> should be no difference between `git am --check` and `git apply
> --check`.

One difference (that still annoys me) is "git apply" must be run at topdir. "git am" can be run anywhere and it will automatically find topdir.

"git am" can also consume multiple patches, so it's some extra work if we just use "git apply" directly, although I don't think that's a very good argument for "am --check".

-- 
Duy