Re: [PATCH v2 21/22] mingw32: add uname()

From: Duy Nguyen <pclouds@gmail.com>
Date: Nov 9, 2014, 08:36 UTC
Message-ID: <CACsJy8CRzngC5U3VY9Bi1uRmdRfEWQWOCokRLLWNKRNUjyJrrw@mail.gmail.com>
In-Reply-To: <CAPig+cS2FzL6kXTvoG6cTX1yUjmGUkEm5mAHNxmtU5-=ngcoFg@mail.gmail.com>

On Sun, Nov 9, 2014 at 10:32 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 19 quoted lines

> On Sat, Nov 8, 2014 at 4:39 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>> diff --git a/compat/mingw.c b/compat/mingw.c
>> index c5c37e5..b817678 100644
>> --- a/compat/mingw.c
>> +++ b/compat/mingw.c
>> @@ -2128,3 +2128,14 @@ void mingw_startup()
>>         /* initialize Unicode console */
>>         winansi_init();
>>  }
>> +
>> +int uname(struct utsname *buf)
>> +{
>> +       DWORD v = GetVersion();
>> +       memset(buf, 0, sizeof(*buf));
>> +       sprintf(buf->sysname, "Windows");
>
> strcpy() maybe?

It was originally strcpy, then I wanted to get fancy and show Win3.1, Win95... but it got complicated (couldn't just do it based on the last bit of 'v'). Will revert.

-- 
Duy