Re: [PATCH] git exproll: steps to tackle gc aggression

From: Duy Nguyen <pclouds@gmail.com>
Date: Aug 10, 2013, 09:50 UTC
Message-ID: <CACsJy8CPM2jwWu0g+mamnA89UtWR=3B=8Q+j2mu-CMB=TRm7Og@mail.gmail.com>
In-Reply-To: <20130810094339.GB2518@sigill.intra.peff.net>

On Sat, Aug 10, 2013 at 4:43 PM, Jeff King <peff@peff.net> wrote:

Show 22 quoted lines

>> push has --thin turned off by default favoring server resources over
>> network traffic, see a4503a1 (Make --no-thin the default in git-push
>> to save server resources - 2007-09-09)
>
> Hmm. I don't think that is the case anymore.
>
> If I do:
>
>   git init parent &&
>   (cd parent && seq 1 10000 >file &&
>    git add file && git commit -m base
>   ) &&
>   git clone parent child &&
>   cd child && seq 1 10001 >file &&
>   git commit -a -m more &&
>   GIT_TRACE=1 git push origin HEAD:foo
>
> I see:
>
>   trace: run_command: 'pack-objects' '--all-progress-implied' '--revs'
>     '--stdout' '--thin' '--delta-base-offset' '--progress'
>

Right. transport_get() is also run for push and it sets smart_options->thin = 1 unconditionally. Thanks for correcting.

-- 
Duy