git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] wildmatch precompilation interface

From
Duy Nguyen <pclouds@gmail.com>
Date
Feb 26, 2018, 11:01 UTC
Message-ID
<CACsJy8COegzVZ99PqsfrDq=uPfQewEZKXF5WK3K6ah62QfQV9g@mail.gmail.com>
In-Reply-To
<20180225203537.28318-1-avarab@gmail.com>

On Mon, Feb 26, 2018 at 3:35 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 9 quoted lines
> My recently landed wildmatch test series was in preperation for some
> more major wildmatch changes.
>
> Here's another series that prepares for bigger changes in wildmatch,
> it adds an interface to pre-compile the patterns. Right now there's no
> point in doing this, and it's harmless since none of the codepaths are
> that performance sensitive, but down the line this'll save us time as
> we'll be able to skip re-parsing the pattern each time with a better
> wildmatch backend.

I don't see any big problem with this, but should this be a standalone series? Some changes look harmless now, but I'd rather see the real precompile implementation to see how it impacts (or benefits) the converted call sites.

-- 
Duy
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 8 of 9 in “wildmatch precompilation interface”
  1. 0/2 wildmatch precompilation interfaceÆvar Arnfjörð Bjarmason, Feb 25, 2018
  2. 1/2 wildmatch: add interface for precompiling wildmatch() patternsÆvar Arnfjörð Bjarmason, Feb 25, 2018
  3. Duy NguyenFeb 26, 2018
  4. Ævar Arnfjörð BjarmasonFeb 26, 2018
  5. 2/2 wildmatch: use the new precompiling wildmatch()Ævar Arnfjörð Bjarmason, Feb 25, 2018
  6. Duy NguyenFeb 26, 2018
  7. Ævar Arnfjörð BjarmasonFeb 26, 2018
  8. Duy NguyenFeb 26, 2018
  9. Ævar Arnfjörð BjarmasonFeb 26, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.