Re: Suggestion on hashing
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Dec 6, 2011, 04:46 UTC
- Message-ID
- <CACsJy8CM8xqWxTx14QbY+-bT=306p3U=6gJfRaW=dDD-Swo7-w@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.2.00.1112060146121.15104@hoki.goeswhere.com>
On Tue, Dec 6, 2011 at 8:56 AM, Chris West (Faux) <faux@goeswhere.com> wrote:
Show 9 quoted lines
> > Nguyen Thai Ngoc Duy wrote: >> >> SHA-1 charateristics (like 20 byte length) are hard coded everywhere >> in git, it'd be a big audit. > > > I was planning to look at this anyway. My branch[1] allows > init/add/commit with SHA-256, SHA-512 and all the SHA-3 candidates.
Great!
> log/fsck/etc. are all broken. Don't even dare try packs. Fixing things > is painful but not impossible. I'm not convinced the task is even > remotely insurmountable.
It would take more work, but after you're done with code changes, you should have a look at updating the test suite. We have many SHA-1s there. If the test suite passes, your job is (beautifully) done.
-- Duy