Re: [PATCH] Specify -Wformat along with -Wformat-security

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 27, 2018, 18:35 UTC
Message-ID: <CACsJy8CM=H1njP3ZzuReS0u_YRPTS6pGhFWWMBHoaKVNBYiXXA@mail.gmail.com>
In-Reply-To: <20181227065855.68632-1-masayasuzuki@google.com>

On Thu, Dec 27, 2018 at 7:18 PM Masaya Suzuki <masayasuzuki@google.com> wrote:

>
> Without -Wformat, -Wformat-security won't work.
>
> > cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]

Compiler name and version?

Show 21 quoted lines

>
> Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
> ---
>  config.mak.dev | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.dev b/config.mak.dev
> index bbeeff44f..aae9db67d 100644
> --- a/config.mak.dev
> +++ b/config.mak.dev
> @@ -7,6 +7,7 @@ CFLAGS += -pedantic
>  CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
>  endif
>  CFLAGS += -Wdeclaration-after-statement
> +CFLAGS += -Wformat
>  CFLAGS += -Wformat-security
>  CFLAGS += -Wno-format-zero-length
>  CFLAGS += -Wold-style-definition
> --
> 2.20.1.415.g653613c723-goog
>

-- 
Duy