Re: [PATCH] wildmatch: change behavior of "foo**bar" in WM_PATHNAME mode
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Oct 29, 2018, 15:53 UTC
- Message-ID
- <CACsJy8CLHQ0mKhKXvTDAqy9TLwEFBSvHEu5UbPxHX4is2mK+Cg@mail.gmail.com>
- In-Reply-To
- <87h8h4lwcv.fsf@evledraar.gmail.com>
On Mon, Oct 29, 2018 at 2:24 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> This patch looks good to me, but I think it's a bad state of affairs to > keep changing these semantics and not having something like a > "gitwildmatch" doc were we document this matching syntax.
While we don't have a separate document for it, the behavior _is_ documented even if perhaps it wasn't as clear. There were even tests for this corner case.
> Do you have any thoughts on how to proceed with getting this documented > / into some stable state where we can specify it?
wildmatch has been used in git for a few years if I remember correctly so to me it is stable. Granted there are corner cases like this, but I can't prevent all bugs (especially this one which is more like design mistake than bug per se). You are welcome to refactor gitignore.txt and add gitwildmatch.txt.
-- Duy