Re: [PATCH 0/5] Number truncation with 4+ GB files on 32-bit systems
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jul 10, 2016, 10:41 UTC
- Message-ID
- <CACsJy8CHsMXJOtr14XYLeU8J6eAwk5rahtkppwxV0JpeXL5yWw@mail.gmail.com>
- In-Reply-To
- <20160705170558.10906-1-pclouds@gmail.com>
On Tue, Jul 5, 2016 at 7:05 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:
> Most of the rest seems harmless, except for the local variable "size" > in builtin/pack-objects.c:write_one(). I might send 6/5 for that one.
This truncated "size" produces incorrect .idx file and makes everybody else fail to read the (correct) .pack file. So 6/5 is coming shortly.
I also add 7/5 to be able to run fsck on 32-bit systems, but 7/5 could help improve performance a bit on 64-bit systems too.
-- Duy