Re: [PATCH] checkout: indicate when a detached head is checked out for a branch

From: Duy Nguyen <pclouds@gmail.com>
Date: Jul 18, 2014, 10:58 UTC
Message-ID: <CACsJy8CG17tzWWO27Pv2c+CjDyYiYATzgBSFfMBaugYgQfZQ5g@mail.gmail.com>
In-Reply-To: <35dbe7e3f3e4566d775bea19d816adc44db8ed5c.1405676303.git.git@drmicha.warpmail.net>

On Fri, Jul 18, 2014 at 4:50 PM, Michael J Gruber <git@drmicha.warpmail.net> wrote:

Show 6 quoted lines

> I really like the new --to feature and will convert all my "new workdir"
> checkouts to that. But that detached checkout is so easy to miss - in fact
> I noticed it only when I compared "new-workdir" to "checkout --to" for a
> test repo with one branch, to see what a converter would need to do.
>
> I'm even wondering whether we should do this DWIMmery at all,

This is what this series needs, user's opinions (bad or good). The other option is abort the checkout immediately. I think I made detach behavior default is because it's more work (and needs to be proven feasible). How about a config key that lets user decide what to do here, abort or detach. We may change the default behavior too if people think the current one is not good.

> given how "dangerous" a detached head is for those who are not aware of it
> before gc kicks in.

Wait, what danger are we talking about? I thought gc pays attention to detached heads as well..

-- 
Duy