git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4] clone --single: limit the fetch refspec to fetched branch

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Sep 18, 2012, 01:02 UTC
Message-ID
<CACsJy8CENp5VasbizzrLRbRELaaPD-gVLepEdXHPv=Diq9s6sg@mail.gmail.com>
In-Reply-To
<7vhaqwv2co.fsf@alter.siamese.dyndns.org>
On Tue, Sep 18, 2012 at 3:08 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> --mirror --single-branch combination does not look right. The "heads/"
>> part is missing..
>
> What does it supposed to do in the first place?  "mirror" is
> primarily about grabbing everything without leaving stuff out, and
> "single" is about grabbing only one thing without other stuff.  It
> smells like a nonsense case we didn't even bother to catch and
> diagnose as an error to me.
>
> Besides, mirror implies bare, so we would expect to see
>
>     refs/heads/$single:refs/heads/$single
>
> and that matches what the "single" gives us without "mirror", no?
Yes that's what I think it should do too.
> How about explicitly forbidding that combination, or ignoring mirror
> when single is given?

I see nothing wrong with mirroring just one branch. But if handling it is too complex than forbidding it is fine.

-- 
Duy
Previous: Junio C HamanoNext: Junio C Hamano
Message 38 of 39 in “is this behaviour expected for "git clone --single-branch"?”
  1. Ralf ThielowSep 13, 2012
  2. Junio C HamanoSep 13, 2012
  3. Ralf ThielowSep 13, 2012
  4. clone: fix refspec on "--single-branch" optionRalf Thielow, Sep 14, 2012
  5. Junio C HamanoSep 14, 2012
  6. Junio C HamanoSep 14, 2012
  7. Nguyen Thai Ngoc DuySep 14, 2012
  8. Ralf ThielowSep 14, 2012
  9. Junio C HamanoSep 14, 2012
  10. [PATCHv2] clone: fix refspec on "--single-branch" optionRalf Thielow, Sep 14, 2012
  11. Junio C HamanoSep 14, 2012
  12. [PATCHv3] clone: fix refspec on "--single-branch" optionRalf Thielow, Sep 14, 2012
  13. Junio C HamanoSep 14, 2012
  14. [PATCHv4] clone --single: limit the fetch refspec to fetched branchRalf Thielow, Sep 16, 2012
  15. Junio C HamanoSep 17, 2012
  16. Nguyen Thai Ngoc DuySep 17, 2012
  17. Nguyen Thai Ngoc DuySep 17, 2012
  18. [PATCHv5] clone --single: limit the fetch refspec to fetched branchRalf Thielow, Sep 17, 2012
  19. Junio C HamanoSep 17, 2012
  20. Ralf ThielowSep 17, 2012
  21. Junio C HamanoSep 17, 2012
  22. Ralf ThielowSep 18, 2012
  23. Junio C HamanoSep 18, 2012
  24. [PATCHv6] clone --single: limit the fetch refspec to fetched branchRalf Thielow, Sep 18, 2012
  25. Junio C HamanoSep 18, 2012
  26. Junio C HamanoSep 18, 2012
  27. [PATCHv7] clone --single: limit the fetch refspec to fetched branchRalf Thielow, Sep 19, 2012
  28. Junio C HamanoSep 19, 2012
  29. [PATCHv8] clone --single: limit the fetch refspec to fetched branchRalf Thielow, Sep 20, 2012
  30. Junio C HamanoSep 20, 2012
  31. Nguyen Thai Ngoc DuySep 19, 2012
  32. Ralf ThielowSep 19, 2012
  33. Junio C HamanoSep 17, 2012
  34. Nguyen Thai Ngoc DuySep 18, 2012
  35. Junio C HamanoSep 18, 2012
  36. Ralf ThielowSep 17, 2012
  37. Junio C HamanoSep 17, 2012
  38. Nguyen Thai Ngoc DuySep 18, 2012
  39. Junio C HamanoSep 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.