Re: Watchman support for git
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- May 14, 2014, 10:52 UTC
- Message-ID
- <CACsJy8CDGP1QwX4C3yKVUOw3h90EcLSXXXy=t6XFSVOrVjxA4A@mail.gmail.com>
- In-Reply-To
- <CACsJy8C49EDwjtv_L2pTRy3XbPptp7+nNzT=Jp4BaH_TOZtvnQ@mail.gmail.com>
One more thing I think we can solve with watchman is the racy timestamp issue (see 29e4d36 and 407c8eb). Basically if a file is updated within a second (and the system only supports timestamp granuarity down to a second) then git can't know if a file is changed by comparing stat data, so it compares content anyway. With watchman, I think we know that a file is updated or not and can disable racy test. How often this happens and whether it is worth supporting is something to think about.
-- Duy