git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/5] enter_repo: avoid duplicating logic, use is_git_directory() instead

From
Duy Nguyen <pclouds@gmail.com>
Date
Sep 13, 2015, 00:49 UTC
Message-ID
<CACsJy8CD+cNdM5EppcStJViRA7yPpyAHyUX=ct4LEK6RCrJrFw@mail.gmail.com>
In-Reply-To
<xmqq8u8i9okf.fsf@gitster.mtv.corp.google.com>
On Mon, Sep 7, 2015 at 11:33 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>
> The cover letter talks about "local clone", and in this entire
> series, I saw new tests only for the local case, but doesn't this
> and the next change also affect the case where a Git daemon or a
> upload-pack process is serving the remote repository?
>
> And if so, how is that case affected?

People who serve .git-dir repos should not be affected (I think we have enough test cases covering that). People can serve .git-file repos as well, which is sort of tested in the local clone test case because upload-pack is involved for providing remote refs, I think. -- Duy

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 28 in “workdirs: cannot clone a local workdir directory”
  1. Bjørnar SnoksrudJul 15, 2015
  2. Duy NguyenJul 15, 2015
  3. 0/5 fix local clone from a linked checkoutNguyễn Thái Ngọc Duy, Aug 22, 2015
  4. 1/5 path.c: delete an extra spaceNguyễn Thái Ngọc Duy, Aug 22, 2015
  5. 2/5 enter_repo: avoid duplicating logic, use is_git_directory() insteadNguyễn Thái Ngọc Duy, Aug 22, 2015
  6. Junio C HamanoSep 7, 2015
  7. Duy NguyenSep 13, 2015
  8. Junio C HamanoSep 13, 2015
  9. Duy NguyenSep 14, 2015
  10. Junio C HamanoSep 21, 2015
  11. 3/5 enter_repo: allow .git files in strict modeNguyễn Thái Ngọc Duy, Aug 22, 2015
  12. 4/5 clone: allow --local from a linked checkoutNguyễn Thái Ngọc Duy, Aug 22, 2015
  13. Junio C HamanoSep 7, 2015
  14. 5/5 clone: better error when --reference is a linked checkoutNguyễn Thái Ngọc Duy, Aug 22, 2015
  15. 0/5 fix local clone from a linked checkoutNguyễn Thái Ngọc Duy, Sep 13, 2015
  16. 1/5 path.c: delete an extra spaceNguyễn Thái Ngọc Duy, Sep 13, 2015
  17. 2/5 enter_repo: avoid duplicating logic, use is_git_directory() insteadNguyễn Thái Ngọc Duy, Sep 13, 2015
  18. 3/5 enter_repo: allow .git files in strict modeNguyễn Thái Ngọc Duy, Sep 13, 2015
  19. Junio C HamanoSep 25, 2015
  20. 4/5 clone: allow --local from a linked checkoutNguyễn Thái Ngọc Duy, Sep 13, 2015
  21. 5/5 clone: better error when --reference is a linked checkoutNguyễn Thái Ngọc Duy, Sep 13, 2015
  22. 0/6 fix local clone from a linked checkoutNguyễn Thái Ngọc Duy, Sep 28, 2015
  23. 1/6 path.c: delete an extra spaceNguyễn Thái Ngọc Duy, Sep 28, 2015
  24. 2/6 t0002: add test for enter_repo(), non-strict modeNguyễn Thái Ngọc Duy, Sep 28, 2015
  25. 3/6 enter_repo: avoid duplicating logic, use is_git_directory() insteadNguyễn Thái Ngọc Duy, Sep 28, 2015
  26. 4/6 enter_repo: allow .git files in strict modeNguyễn Thái Ngọc Duy, Sep 28, 2015
  27. 5/6 clone: allow --local from a linked checkoutNguyễn Thái Ngọc Duy, Sep 28, 2015
  28. 6/6 clone: better error when --reference is a linked checkoutNguyễn Thái Ngọc Duy, Sep 28, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.