Re: [PATCH v2 0/4] Deprecate "not allow as-is commit with i-t-a entries"

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Feb 9, 2012, 02:23 UTC
Message-ID: <CACsJy8CC-VuriJO3WhzwwU9WYVuC7hudnziopd1+upp6AFLYfQ@mail.gmail.com>
In-Reply-To: <7v8vkdz0sg.fsf@alter.siamese.dyndns.org>

On Thu, Feb 9, 2012 at 12:34 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Ok, the strategy part is now behind us, but I have this slight suspicion
> (I didn't look at the code nor tried it out myself---I don't have time to
> do this myself today) that using this codepath might result in a corrupt
> cache-tree, whose entries point at a section of the index it covers as a
> subtree of the whole project but with incorrect counters or something like
> that.  It would be good to make sure this "just ignoring i-t-a" is doing
> the right thing not to the resulting commit, but in the resulting index as
> well, before we go forward with this change.

I looked a little bit and I think i-t-a entries do not break cache-tree. CE_REMOVE ones might though because they are taken into account in entry_count field, but they are not written down to file. Will look into it tonight.

-- 
Duy