Re: [PATCHv4 2/2] submodule: port init from shell to C

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 27, 2016, 08:30 UTC
Message-ID: <CACsJy8C7t9LEVaEqS9GRQ3oYmXwRp33=qOo-+4R4urHco25bAA@mail.gmail.com>
In-Reply-To: <1453948237-9860-3-git-send-email-sbeller@google.com>

On Thu, Jan 28, 2016 at 9:30 AM, Stefan Beller <sbeller@google.com> wrote:

Show 14 quoted lines

> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index 13583d9..689c354 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> +static int module_init(int argc, const char **argv, const char *prefix)
> +{
> +       int quiet = 0;
> +       int i;
> +
> +       struct option module_init_options[] = {
> +               OPT_STRING(0, "prefix", &prefix,
> +                          N_("path"),
> +                          N_("alternative anchor for relative paths")),
> +               OPT__QUIET(&quiet, "Suppress output for initialzing a submodule"),

I think we need N_() around this "Suppress..." string. By the way, typo in "initializing"

-- 
Duy