Re: commit: support commit.verbose and --no-verbose
On Sat, May 24, 2014 at 4:22 AM, Caleb Thompson <cjaysson@gmail.com> wrote:
> This patch allows people to set `commit.verbose` to implicitly send `--verbose`
> to `git commit`. It also introduces `--no-verbose` to override the configuration
> setting.
The code change looks fine to me (no opinion if we should do this though).
Show 11 quoted lines
> --- a/Documentation/git-commit.txt
> +++ b/Documentation/git-commit.txt
> @@ -282,7 +282,14 @@ configuration variable documented in linkgit:git-config[1].
> Show unified diff between the HEAD commit and what
> would be committed at the bottom of the commit message
> template. Note that this diff output doesn't have its
> - lines prefixed with '#'.
> + lines prefixed with '#'. The `commit.verbose` configuration
> + variable can be set to true to implicitly send this option.
> +
> +-V::
No, I don't think -V is the negative form of -v if you use OPT_BOOL().
> +--no-verbose::
> + Do not show the unified diff at the bottom of the commit message
> + template. This is the default behavior, but can be used to override
> + the`commit.verbose` configuration variable.
--
Duy
Duy Nguyen <pclouds@gmail.com>