Re: [PATCH] packfile: Correct zlib buffer handling

From: Duy Nguyen <pclouds@gmail.com>
Date: May 26, 2018, 05:51 UTC
Message-ID: <CACsJy8C4zNZAe6Vw-mz8r8HueYdQKs4ZhMOQYX0v7ypfHdmShg@mail.gmail.com>
In-Reply-To: <20180525225601.22575-1-lintonrjeremy@gmail.com>

On Sat, May 26, 2018 at 12:56 AM, Jeremy Linton <lintonrjeremy@gmail.com> wrote:

Show 6 quoted lines

> @@ -1416,7 +1416,7 @@ static void *unpack_compressed_entry(struct packed_git *p,
>                 return NULL;
>         memset(&stream, 0, sizeof(stream));
>         stream.next_out = buffer;
> -       stream.avail_out = size + 1;
> +       stream.avail_out = size;

You may want to include in your commit message a reference to
39eea7bdd9 (Fix incorrect error check while reading deflated pack data
- 2009-10-21) which adds this plus one with a fascinating story
behind.

-- 
Duy