Re: [PATCH 0/9] i18n: add PO files to po/

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Oct 3, 2011, 22:53 UTC
Message-ID: <CACsJy8C1-YaON868Vtn0=o8U0hL=OChVOKydz6A1SmjpSkgUUw@mail.gmail.com>
In-Reply-To: <20111003220659.GA19537@elie>

On Tue, Oct 4, 2011 at 9:06 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 7 quoted lines

> 3. Maybe some hero will implement
>
>        git log -p --exclude=po/
>        # or
>        git log -p -- :(not)po/
>
> to complement "git log -p -- po/". ;-)

I was pursuing the latter, but think again, maybe reuse exclude code to implement --exclude would be wiser.

One of my motives for negative pathspec is to narrow/extend a narrow clone. Narrow clone itself should reuse sparse checkout for worktree part, and sparse checkout uses exclude code already. If I go with negative pathspec for narrow clone, I would need to invent another negative-path-based sparse checkout.. That does not make much sense.

I believe a couple of lines in process_trees() in list-objects.c and adding struct exclude_list* to struct rev_info would be enough for --exclude, if you want to try.

-- 
Duy