Re: [PATCH] checkout: add --sparse for restoring files in sparse checkout mode

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 25, 2013, 01:34 UTC
Message-ID: <CACsJy8ByH8U0wYuaKaMKd3bauLBbS52peMs1eiGz++2vj2JKTA@mail.gmail.com>
In-Reply-To: <20130324181752.GA4543@elie.Belkin>

On Mon, Mar 25, 2013 at 1:17 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 22 quoted lines

>> +--sparse::
>> +     In sparse checkout mode, `git checkout -- <paths>` would
>> +     update all entries matched by <paths> regardless sparse
>> +     patterns. This option only updates entries matched by <paths>
>> +     and sparse patterns.
>
> Hm, should this be the default?
>
> In principle, I would expect
>
>         git checkout -- .
>
> to make the worktree match the index, respecting the sparse checkout.
> And something like
>
>         git checkout --widen -- .
>
> to change the sparse checkout pattern.  But of course it is easily
> possible that I am missing some details of how sparse checkout is
> used in practice.
>
> What do you think?

Changing the default may involve a painful transition phase (e.g. "add -u"). I think making it the default via alias should be good enough in most cases. We also need to think how it impacts checkout usage in scripts. I think it might be ok, but I haven't finished my morning coffee yet, so..

-- 
Duy