Re: [RFC] Add basic syntax check on shell scripts
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Dec 4, 2012, 07:20 UTC
- Message-ID
- <CACsJy8BxviWRHqGvptsJVmkFM6HQa9HnLWsh5V6Ec6Fqv52sGA@mail.gmail.com>
- In-Reply-To
- <7vzk1vrs63.fsf@alter.siamese.dyndns.org>
On Mon, Dec 3, 2012 at 11:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes: > >> The test suite needs to be run on different platforms. >> As it may be difficult for contributors to catch syntax >> which work on GNU/linux, but is unportable, make a quick check >> for the most common problems. >> "sed -i", "echo -n" or "array in shell scripts" >> This list is not complete, and may need to be extended >> >> Signed-off-by: Torsten Bögershausen <tboegi@web.de> >> --- >> We add 1 second test execution time >> Is this a useful idea at all? > > Please do not name it after t/t[0-9]*.sh pattern, which are about > testing git. > > This (once it gets cleaned up to reduce false positives) belongs to > "cd t && make test-lint".
Or a project commit hook? We can see how it goes and whether we can improve anything for projects that rely on hooks.
-- Duy