Re: [PATCH 2/6] t1406: prepare for the refs code to fail with BUG()

From: Duy Nguyen <pclouds@gmail.com>
Date: May 1, 2018, 11:22 UTC
Message-ID: <CACsJy8BugBtVBZpL+1S5ix+UQzxPaM_L1bBio1fgED5ZQ2XfNA@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1805011257400.79@tvgsbejvaqbjf.bet>

On Tue, May 1, 2018 at 1:04 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 7 quoted lines

>> If SIGABRT occurs as a result of BUG(), and we know that this happens for
>> certain cases, it means we have an unfixed bug.
>
> Not in this case: The code in question is in
> https://github.com/git/git/blob/v2.17.0/t/helper/test-ref-store.c#L190-L201
> and it is called in a way that fails to have the required flags for the
> operation.

To elaborate, in this particular case, developers are not supposed to call calling create_reflog() on a submodule ref store because the store's implementation does not support it (yet). So it's definitely BUG() to catch devs from doing so. But due to the multiple layer abstractions, we also need to verify that ref code will bug out in this case :P

> This would normally indicate a bug, but in this case, that is
> exactly what the regression test tries to trigger: we *want* such a bug to
> cause a failure.

-- 
Duy