git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] read_directory: avoid invoking exclude machinery on tracked files

From
Duy Nguyen <pclouds@gmail.com>
Date
Feb 16, 2013, 03:31 UTC
Message-ID
<CACsJy8BgDZCfWLZT4kNa+Qt5n7YZJ_wemh9gKbrtimbjcmj+sg@mail.gmail.com>
In-Reply-To
<7vd2w1gyok.fsf@alter.siamese.dyndns.org>
On Sat, Feb 16, 2013 at 2:32 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
>> If you consider read_directory_recursive alone, there is a regression.
>> The return value of r_d_r depends on path_handled/path_ignored. With
>> this patch, the return value will be different.
>
> That is exactly what was missing from the proposed log message, and
> made me ask "Do all the callers that reach this function in their
> callgraph, when they get path_ignored for a path in the index,
> behave as if the difference between path_ignored and path_handled
> does not matter?"

I'll add it the the log message. Although I'm thinking some restructuring to separate tracked file handling from the rest may make it clearer (and less error prone in future).

-- 
Duy
Previous: Junio C HamanoNext: Karsten Blees
Message 5 of 12 in “read_directory: avoid invoking exclude machinery on tracked files”
  1. read_directory: avoid invoking exclude machinery on tracked filesNguyễn Thái Ngọc Duy, Feb 15, 2013
  2. Junio C HamanoFeb 15, 2013
  3. Duy NguyenFeb 15, 2013
  4. Junio C HamanoFeb 15, 2013
  5. Duy NguyenFeb 16, 2013
  6. Karsten BleesFeb 18, 2013
  7. read_directory: avoid invoking exclude machinery on tracked filesNguyễn Thái Ngọc Duy, Feb 16, 2013
  8. Pete WyckoffFeb 16, 2013
  9. Duy NguyenFeb 17, 2013
  10. Pete WyckoffFeb 17, 2013
  11. Junio C HamanoFeb 17, 2013
  12. dir.c: Make git-status --ignored even more consistentKarsten Blees, Feb 25, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.