Re: [PATCH v5 06/15] index-helper: add --detach

From: Duy Nguyen <pclouds@gmail.com>
Date: Apr 19, 2016, 23:50 UTC
Message-ID: <CACsJy8Bcb=-V0wc8En2SCSz8jPefEL4qibxJsLsTB-c94x9y3Q@mail.gmail.com>
In-Reply-To: <1461108489-29376-7-git-send-email-dturner@twopensource.com>

On Wed, Apr 20, 2016 at 6:28 AM, David Turner <dturner@twopensource.com> wrote:

Show 6 quoted lines

> @@ -317,6 +320,8 @@ int main(int argc, char **argv)
>         if (fd < 0)
>                 die_errno(_("could not set up index-helper socket"));
>
> +       if (detach && daemonize(&daemonized))
> +               die_errno(_("unable to detach"));

At the least, I think we need to redirect both stdout and stderr to a file, so we can catch errors. The watchman patch uses warning() to report errors, for example. And there is always a chance of die().

Then we need to report the errors back. I faced the same problem with daemonizing git-gc, but I'm not sure if we can do exactly the same here like in commit 329e6e8 (gc: save log from daemonized gc --auto and print it next time - 2015-09-19)

-- 
Duy