Re: [PATCH] commit.c: use the generic "sha1_pos" function for lookup sha1
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Feb 26, 2014, 10:53 UTC
- Message-ID
- <CACsJy8BQKHuvLpCQMuVK79owdoTbHkS0k3yNJ_9fyvDiJooJgg@mail.gmail.com>
- In-Reply-To
- <530DBCF3.9060801@yandex.ru>
On Wed, Feb 26, 2014 at 5:07 PM, Dmitry S. Dolzhenko <dmitrys.dolzhenko@yandex.ru> wrote:
> Refactor binary search in "commit_graft_pos" function: use > generic "sha1_pos" function.
For fun, try to break your changes deliberately then run "make test" and see if the failed tests can lead you back to this function. I hear some people gather in irc. I think they could help you faster when you need to track this code. Else get support from this mailing list. If the test suite does not detect it at all, you can add new tests to cover it.
-- Duy