Re: [PATCH 0/6] Merge remaining t/helper binaries to test-tool

From: Duy Nguyen <pclouds@gmail.com>
Date: Sep 9, 2018, 18:24 UTC
Message-ID: <CACsJy8BJYKBcPZeTwP4_0bUsDM4uRxafS77T6RnG9U6h_t2y5g@mail.gmail.com>
In-Reply-To: <87o9d6lezg.fsf@evledraar.gmail.com>

On Sun, Sep 9, 2018 at 8:09 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 13 quoted lines

>
>
> On Sun, Sep 09 2018, Nguyễn Thái Ngọc Duy wrote:
>
> > Last time when I added test-tool in 27f25845cf (Merge branch
> > 'nd/combined-test-helper' - 2018-04-11) I left out a few test programs
> > because there were a couple in-flight new tests that used them. All
> > those topics are merged now. So we can merge these to test-tool and
> > call it done.
>
> This is great. Just a small side-note: Am I the only one who misses the
> 2.8.0 days when you could do "git clean -dxff" in the t/ directory to
> clean up various test crap without breaking subsequent tests?

Isn't "make clean" (in t/) enough?

Show 5 quoted lines

> That went away in e6e7530d10 ("test helpers: move test-* to t/helper/
> subdirectory", 2016-04-13) when we started building stuff in t/helper/.
>
> So now that this is one binary perhaps we can build it in the root
> directory and get that functionality back?

It's still a few binaries. Most of them are now merged to test-tool, but ones that need separate program name, or have extra deps, stay separate. Having said that, producing the binaries at root directory is possible. I'm just not sure if it's worth doing.

-- 
Duy