Re: [PATCH v2 03/10] cat-file: use streaming interface to print blobs
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Mar 5, 2012, 02:42 UTC
- Message-ID
- <CACsJy8BFW_LhsoL_ickLopnnMBj10rn-9QcoqmXML8Uau74S5A@mail.gmail.com>
- In-Reply-To
- <7vling6jw2.fsf@alter.siamese.dyndns.org>
2012/3/5 Junio C Hamano <gitster@pobox.com>:
Show 10 quoted lines
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> +static int write_blob(const unsigned char *sha1)
>> +{
>> + unsigned char new_sha1[20];
>> +
>> + if (sha1_object_info(sha1, NULL) == OBJ_TAG) {
>
> Hrm, didn't I say that it tastes bad for a function write_blob() to have
> to worry about OBJ_TAG already?My bad. Reworked, added another test case for the dereference case, and clone exceeded memory limit again due to new test case :( Will need some more work on this.
-- Duy