git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG?] fetch into shallow sends a large number of objects

From
Duy Nguyen <pclouds@gmail.com>
Date
Mar 8, 2016, 23:02 UTC
Message-ID
<CACsJy8BFK64rzJwQxB8M3=uA_g9s6N70vjNyLOnroZc28soiAQ@mail.gmail.com>
In-Reply-To
<20160308133041.GA9465@sigill.intra.peff.net>
On Tue, Mar 8, 2016 at 8:30 PM, Jeff King <peff@peff.net> wrote:
Show 17 quoted lines
> On Tue, Mar 08, 2016 at 08:25:24AM -0500, Jeff King wrote:
>
>> > Good news. We have the mechanism in place, I think.
>> > get_shallow_commits_by_rev_list() (from 'pu') will produce the right
>> > shallow points for sending back to the client if you pass "--not
>> > <current shallow points>" to it. It's meant to be used for
>> > --shallow-exclude and --shallow-since, but if neither is given (nor
>> > --depth) I guess we can run it with current shallow points. I wonder
>> > if we can detect some common cases and avoid commit traversing this
>> > way though.
>>
>> I tried that, but I couldn't quite get it to work. I don't think we need
>> any special rev-list, though; we can just find the boundary points of
>> that traversal and mark them as new shallows.
>
> By the way, I found a bug during my initial attempts with
> get_shallow_commits_by_rev_list().

Hehe. Thanks. Will check why tests missed it and reroll with Ramsay's fix once -rc period is over.

-- 
Duy
Previous: Jeff KingNext: Duy Nguyen
Message 9 of 16 in “[BUG?] fetch into shallow sends a large number of objects”
  1. Jeff KingMar 7, 2016
  2. Junio C HamanoMar 7, 2016
  3. Duy NguyenMar 8, 2016
  4. Jeff KingMar 8, 2016
  5. Jeff KingMar 8, 2016
  6. Duy NguyenMar 8, 2016
  7. Jeff KingMar 8, 2016
  8. Jeff KingMar 8, 2016
  9. Duy NguyenMar 8, 2016
  10. Duy NguyenMar 10, 2016
  11. Jeff KingMar 10, 2016
  12. Junio C HamanoMar 10, 2016
  13. Jeff KingMar 10, 2016
  14. Duy NguyenMar 11, 2016
  15. Junio C HamanoMar 11, 2016
  16. Jeff KingMar 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.