Re: [PATCH 0/3] Wider exposure for index-v4

From: Duy Nguyen <pclouds@gmail.com>
Date: Feb 16, 2014, 01:16 UTC
Message-ID: <CACsJy8BDerqeua6zjGhniy_kxruDk9WuTJY-2zi6m4EpE9=CBg@mail.gmail.com>
In-Reply-To: <1392492197-7724-1-git-send-email-t.gummerer@gmail.com>

On Sun, Feb 16, 2014 at 2:23 AM, Thomas Gummerer <t.gummerer@gmail.com> wrote:

> Hi,
>
> since index-v5 didn't seem to generate enough interest to be merged, I

I thought there were some comments last time that you were going to address and resubmit?

> have a few patches that give users users easier access to index-v4.
> Until now users have to go into the source code and compile git
> themselves to use index-v4 by default, or use git-update-index to
> change the index file to the new version.

Not objecting this, but I think something like [1] would give v4 more exposure. Reading the patch again, I think putting that detection code in unpack_trees() or git-merge may make more sense because people will be advised about upgrading to v4 at the next fast-forward.

[1] http://article.gmane.org/gmane.comp.version-control.git/216307

Show 33 quoted lines

> With this patches it's possible to set the default index file format
> either in gitconfig or in an environment variable.  It also simplifies
> testing index-v4 by adding a Makefile knob to use it for running the
> test suite.  For safety, existing repositories are not changed when
> the environment or the config variables are set.
>
> I'm not sure about the precedence in patch 3, right now the environment
> variable has precedence, but it should be easy to give the config
> option precedence over that.
>
> Thomas Gummerer (3):
> introduce GIT_INDEX_VERSION environment variable
> test-lib: allow setting the index format version
> read-cache: add index.version config variable
>
> Documentation/config.txt              |  4 +++
> Documentation/git.txt                 |  5 ++++
> Makefile                              |  7 +++++
> read-cache.c                          | 36 +++++++++++++++++++++++-
> t/t1600-index.sh                      | 52 +++++++++++++++++++++++++++++++++++
> t/t2104-update-index-skip-worktree.sh |  2 ++
> t/test-lib-functions.sh               |  5 ++++
> t/test-lib.sh                         |  3 ++
> 8 files changed, 113 insertions(+), 1 deletion(-)
> create mode 100755 t/t1600-index.sh
>
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Duy