git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] exclude: reuse last basename comparison

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Jun 8, 2012, 02:37 UTC
Message-ID
<CACsJy8BChqegyvo8Oqj6Rk+kWR245sSngWeQcBZXKWLgTw9t_w@mail.gmail.com>
In-Reply-To
<7vd35bge2u.fsf@alter.siamese.dyndns.org>
On Fri, Jun 8, 2012 at 1:40 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>> diff --git a/dir.c b/dir.c
>> index 94fe9f8..2964076 100644
>> --- a/dir.c
>> +++ b/dir.c
>> @@ -511,6 +511,7 @@ int excluded_from_list(const char *pathname,
>>                      struct exclude_list *el)
>>  {
>>       int i;
>> +     int last_basecmp = el->nr, basecmp_result;
>
> Gcc complains that basecmp_result may be used without initialized in
> this function.
I'm pretty sure it's fault positive.
-- 
Duy
Previous: Junio C Hamano
Message 7 of 7 in “Unindent excluded_from_list()”
  1. 1/4 Unindent excluded_from_list()Nguyễn Thái Ngọc Duy, Jun 7, 2012
  2. 2/4 dir.c: get rid of the wildcard symbol set in no_wildcard()Nguyễn Thái Ngọc Duy, Jun 7, 2012
  3. 3/4 exclude: do strcmp as much as possible before fnmatchNguyễn Thái Ngọc Duy, Jun 7, 2012
  4. 4/4 exclude: reuse last basename comparisonNguyễn Thái Ngọc Duy, Jun 7, 2012
  5. Junio C HamanoJun 7, 2012
  6. Junio C HamanoJun 7, 2012
  7. Nguyen Thai Ngoc DuyJun 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.