Re: [PATCH v3] upload-pack: send shallow info over stdin to pack-objects

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 6, 2014, 23:13 UTC
Message-ID: <CACsJy8B8=N6R6nVa12jjhxdqxMA2eGXOV6jR-XqRRbb-6Xppdg@mail.gmail.com>
In-Reply-To: <xmqqfvmvyxzv.fsf@gitster.dls.corp.google.com>

On Fri, Mar 7, 2014 at 1:37 AM, Junio C Hamano <gitster@pobox.com> wrote:

> I like what I see in this patch, but I wonder if we can essentially
> revert that "temporary shallow file" patch and replace it with the
> same (or a similar) mechanism uniformly?

Using --shallow-file is uniform.The only downside is temporary file. Without it you'll need to think of a way (probably different way for each command) to feed shallow info to.

Show 5 quoted lines

> On the receive-pack side, the comment at the bottom of
> preprare_shallow_update() makes it clear that, if we wanted to use
> hooks, we cannot avoid having the proposed new shallow-file in a
> temporary file, which is unfortunate.  Do we have a similar issue on
> hooks on the upload-pack side?

No. I don't think we have hooks on upload-pack.

Show 7 quoted lines

>>  builtin/pack-objects.c   |  7 +++++++
>>  shallow.c                |  2 ++
>>  t/t5537-fetch-shallow.sh | 13 +++++++++++++
>>  upload-pack.c            | 21 ++++++++++++---------
>>  4 files changed, 34 insertions(+), 9 deletions(-)
>
> Nothing for Documentation/ anywhere?

Heh git-pack-objects.txt never described stdin format. At least I searched for --not in it and found none. So I gladly accepted the situation and skipped doc update :D

-- 
Duy