Re: [PATCH] fix hang in git fetch if pointed at a 0 length bundle

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Jan 3, 2012, 12:07 UTC
Message-ID: <CACsJy8B5B2bx7WK7ViziseuWCPaMgcc-avwtsw2DybRme8Vgfg@mail.gmail.com>
In-Reply-To: <20120103011352.GA13825@localhost>

On Tue, Jan 3, 2012 at 8:13 AM, Brian Harring <ferringb@gmail.com> wrote:

Show 9 quoted lines

> @@ -31,7 +31,7 @@ static int strbuf_readline_fd(struct strbuf *sb, int fd)
>        while (1) {
>                char ch;
>                ssize_t len = xread(fd, &ch, 1);
> -               if (len < 0)
> +               if (len <= 0)
>                        return -1;
>                strbuf_addch(sb, ch);
>                if (ch == '\n')

I think it should return 0 when len == 0 because strictly speaking eof is not a fault. It's not really important though because the two callers in this file work fine either way.

FWIW I went through all xread call sites. All seem to handle return value <= 0 correctly.

-- 
Duy