Re: [PATCH] diff --no-index: support more than one file pair

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Jan 12, 2012, 17:40 UTC
Message-ID: <CACsJy8B460CwtACV+o0wnwqi1On_oEavLfDAL8f=w6kyfktKcQ@mail.gmail.com>
In-Reply-To: <vpqmx9te08z.fsf@bauges.imag.fr>

On Thu, Jan 12, 2012 at 4:30 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 5 quoted lines

>>  - might be easier to script (just throw them all to xargs)
>
> I don't see a use-case where a command produces old1 new1 old2 new2, but
> if there is one, then "| xargs -n 2 diff" is the solution. You don't
> need your patch.

Unthorough thought. I agree with you.

Show 6 quoted lines

>>  - hell, i might even benefit from git copy/modify detection
>
> I don't see how, if you specify explicitely the pairs (old, new). You
> may have such benefit if you let the command-line express "here's a
> bunch of old files, and a bunch of new ones", but not with your proposed
> syntax.

That's what git gives to diff machinery: a set of file pairs, and the diff machinery has to figure out copy/modify pairs, shuffling them up if necessary. I simply cut of tree traversal part out and feed file pairs directly to diff machinery. I remember long long time ago Junio asked for assistance about code moving support within a file. It has not come up (at least in public), but one can hope it'll come someday.

-- 
Duy