Re: [RFC/PATCH] add: warn when -u or -A is used without filepattern
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jan 22, 2013, 01:10 UTC
- Message-ID
- <CACsJy8B1=3gMfGUf3kyea9TyZmr1J7dbM1_+huMNrep24hwuiQ@mail.gmail.com>
- In-Reply-To
- <1358769611-3625-1-git-send-email-Matthieu.Moy@imag.fr>
On Mon, Jan 21, 2013 at 7:00 PM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
Show 17 quoted lines
> Most git commands that can be used with our without a filepattern are > tree-wide by default, the filepattern being used to restrict their scope. > A few exceptions are: 'git grep', 'git clean', 'git add -u' and 'git add -A'. > > The inconsistancy of 'git add -u' and 'git add -A' are particularly > problematic since other 'git add' subcommands (namely 'git add -p' and > 'git add -e') are tree-wide by default. > > Flipping the default now is unacceptable, so this patch starts training > users to type explicitely 'git add -u|-A :/' or 'git add -u|-A .', to prepare > for the next steps: > > * forbid 'git add -u|-A' without filepattern (like 'git add' without > option) > > * much later, maybe, re-allow 'git add -u|-A' without filepattern, with a > tree-wide scope.
What about 'grep' and 'clean'? I think at least 'clean' should go tree-wide default too. I don't mind grep go the same way either but I think people voiced preference in current behavior..
-- Duy