Re: [PATCH v2 6/7] gc: don't run "reflog expire" when keeping reflogs
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Mar 15, 2019, 10:05 UTC
- Message-ID
- <CACsJy8B=76dMKhvdzOyyOMK5o-s8t+77ZE-hBmezhxLdv7E9dQ@mail.gmail.com>
- In-Reply-To
- <20190314123439.4347-7-avarab@gmail.com>
On Thu, Mar 14, 2019 at 7:35 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 6 quoted lines
> @@ -127,6 +140,10 @@ static void gc_config(void)
> pack_refs = git_config_bool("gc.packrefs", value);
> }
>
> + if (gc_config_is_timestamp_never("gc.reflogexpire") &&
> + gc_config_is_timestamp_never("gc.reflogexpireunreachable"))Nit. configset api normalizes the key internally, so we can safely write gc.reflogExpireUnreachable here, which is a bit easier to read.
-- Duy