git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 6/9] Use remote_odb_get_direct() and has_remote_odb()

From
Duy Nguyen <pclouds@gmail.com>
Date
Jul 22, 2018, 09:05 UTC
Message-ID
<CACsJy8B+NBgKFZbrN2etgkecv6yH4NGWogVqzK0K=01MSO2naQ@mail.gmail.com>
In-Reply-To
<20180713174959.16748-7-chriscool@tuxfamily.org>

On Fri, Jul 13, 2018 at 7:50 PM Christian Couder <christian.couder@gmail.com> wrote:

Show 8 quoted lines
> @@ -477,8 +478,8 @@ static int batch_objects(struct batch_options *opt)
>
>                 for_each_loose_object(batch_loose_object, &sa, 0);
>                 for_each_packed_object(batch_packed_object, &sa, 0);
> -               if (repository_format_partial_clone)
> -                       warning("This repository has extensions.partialClone set. Some objects may not be loaded.");
> +               if (has_remote_odb())
> +                       warning("This repository uses an odb. Some objects may not be loaded.");

I can see the string is not marked for translation before, but since you're updating it, please consider _() if needed. Maybe also say "remote object database" instead of odb

-- 
Duy
Previous: Christian CouderNext: Christian Couder
Message 8 of 11 in “Introducing remote ODBs”
  1. 0/9 Introducing remote ODBsChristian Couder, Jul 13, 2018
  2. 1/9 fetch-object: make functions return an error codeChristian Couder, Jul 13, 2018
  3. 2/9 Add initial remote odb supportChristian Couder, Jul 13, 2018
  4. 3/9 remote-odb: implement remote_odb_get_direct()Christian Couder, Jul 13, 2018
  5. 4/9 remote-odb: implement remote_odb_get_many_direct()Christian Couder, Jul 13, 2018
  6. 5/9 remote-odb: add remote_odb_reinit()Christian Couder, Jul 13, 2018
  7. 6/9 Use remote_odb_get_direct() and has_remote_odb()Christian Couder, Jul 13, 2018
  8. Duy NguyenJul 22, 2018
  9. 7/9 Use odb.origin.partialclonefilter instead of core.partialclonefilterChristian Couder, Jul 13, 2018
  10. 8/9 t0410: test fetching from many promisor remotesChristian Couder, Jul 13, 2018
  11. 9/9 Documentation/config: add odb.<name>.promisorRemoteChristian Couder, Jul 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.