Re: [PATCH] add: don't complain when adding empty project root
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Dec 24, 2013, 23:49 UTC
- Message-ID
- <CACsJy8ApEBq+G+swpBPPJwL1E94x-P+e+V_jYknG+rXybLxPgQ@mail.gmail.com>
- In-Reply-To
- <52BA0110.4050003@web.de>
On Wed, Dec 25, 2013 at 4:48 AM, Torsten Bögershausen <tboegi@web.de> wrote:
Show 16 quoted lines
> On 2013-12-24 00.46, Duy Nguyen wrote: >> > [snip] >> We don't complain about adding an empty directory before or after this patch. > Ok, thanks for the explanation. > > I think that > https://www.kernel.org/pub/software/scm/git/docs/git-add.html > could deserve an update. > > My understanding is that <filepattern> is related to $GIT_DIR, > but "." is the current directory. > > I will be happy to write a patch, > (or to review one, whatever comes first) > /Torsten
filepattern is related to current directory too (e.g. "*.sh" from "t" won't cover git-rebase.sh, ":/*.sh" does). Yes a patch to update git-add.txt to use the term "pathspec" instead of "filepattern" would be nice. A pointer to pathspec glossary could help discover case-insensitive matching, negative matching..
-- Duy