Re: [PATCH] wildmatch: correct isprint and isspace

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Nov 16, 2012, 04:19 UTC
Message-ID: <CACsJy8AnghB1F8pwHbZpZJKoCZqbQ-TWpV9x_+49ZEJdE0bW2g@mail.gmail.com>
In-Reply-To: <50A522B5.7080206@cs.tu-berlin.de>

On Fri, Nov 16, 2012 at 12:13 AM, "Jan H. Schönherr" <schnhrr@cs.tu-berlin.de> wrote:

Show 17 quoted lines

>>  #define isprint(x) (sane_istest(x, GIT_ALPHA | GIT_DIGIT | GIT_SPACE | \
>>               GIT_PUNCT | GIT_REGEX_SPECIAL | GIT_GLOB_SPECIAL | \
>> -             GIT_PATHSPEC_MAGIC))
>> +             GIT_PATHSPEC_MAGIC) && \
>> +             (x) >= 32)
>
> May I suggest the current is_print() implementation in master:
>
> #define isprint(x) ((x) >= 0x20 && (x) <= 0x7e)
>
>
> To summarize my opinion:
>
> I no longer see a reason to correct isspace() (unless somebody with an actual
> use case complains), and a more POSIXly isprint() is already in master.
>
> => Nothing to do. :)

Yeah. I remember to remind myself to check "the implementation in master" you mentioned but I probably failed at that. Just checked that isprint() is already in master, and your comment about isspace() use in wildmatch.c makes sense too. So I'm all for doing nothing.

-- 
Duy