Re: Running 'git worktree add' in 'pre-commit' hook

From: Duy Nguyen <pclouds@gmail.com>
Date: May 16, 2019, 11:44 UTC
Message-ID: <CACsJy8AgzSZ_Gj9JW2yTdgkGQNCMMLy8i+pH_+A93+V95anQWQ@mail.gmail.com>
In-Reply-To: <CAPig+cS1iypB9oZ+O=KsJ7CHyWUEOKzr8djRthrXMdC+uNHVKA@mail.gmail.com>

On Thu, May 16, 2019 at 6:39 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 20 quoted lines

>
> On Thu, May 16, 2019 at 7:33 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
> > I researched this also and concluded that it's a bug in git-commit.
> > You run afoul of it in other situations, as well. For instance, say
> > you have your index file in a non-standard location:
> >
> >     $ export GIT_INDEX_FILE=../storage/index
> >     $ git worktree add --detach other
> >     Preparing worktree (detached HEAD c9156d2)
> >     fatal: Unable to create '/.../foo/other/../storage/index.lock': No
> > such file or directory
> >     $
> >
> > I think the correct fix is for git-commit to assign GIT_INDEX_FILE
> > with the absolute path to the index file, not a relative path.
>
> Thinking more clearly on it, a better fix might be for git-worktree to
> deal with this itself, converting such a path to absolute before
> cd'ing to the new worktree directory (or something -- I don't have the
> code in front of me to provide a more concrete suggestion).

Our mails crossed. But yeah it's basically the same thing.

Although I still doubt a good $GIT_INDEX_FILE would fix the problem. Even if you manage to create a new worktree, when you cd there and start using it, this $GIT_INDEX_FILE will still mess things up (unless you do mean to ignore the worktree's index file and update one provided by pre-commit hook).

-- 
Duy