git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Makefile: add option to disable automatic dependency generation

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Nov 18, 2011, 10:07 UTC
Message-ID
<CACsJy8AY9bFR_DXnOhbfMGFBD4Ep6OmKF4EiCgUdNiZi-rjMLA@mail.gmail.com>
In-Reply-To
<20111118095820.GF25145@elie.hsd1.il.comcast.net>
On Fri, Nov 18, 2011 at 4:58 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 28 quoted lines
> Now that the COMPUTE_HEADER_DEPENDENCIES feature is turned on
> automatically for compilers that support it (see v1.7.8-rc0~142^2~1,
> 2011-08-18), there is no easy way to force it off.  For example,
> setting COMPUTE_HEADER_DEPENDENCIES to the empty string in config.mak
> just tells the makefile to treat it as undefined and run a test
> command to see if the -MMD option is supported.
>
> So allow setting COMPUTE_HEADER_DEPENDENCIES=no to explicitly force
> the feature off.  The new semantics:
>
>  - "yes" means to explicitly enable the feature
>  - "no" means to disable it
>  - "auto" means to autodetect
>
> The default is still "auto".  Any value other than these three will
> cause the build to error out with a descriptive message so typos and
> stale settings in config.mak don't result in mysterious behavior.
>
>        Makefile:1278: *** please set COMPUTE_HEADER_DEPENDENCIES to
>        yes, no, or auto (not "1").  Stop.
>
> So now when someone using a compiler without -MMD support reports
> trouble building git, you can reproduce it by running "make
> COMPUTE_HEADER_DEPENDENCIES=no".
>
> Suggested-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> Improved-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Tested-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
-- 
Duy
Previous: Jonathan NiederNext: Jonathan Nieder
Message 17 of 19 in “A flaw in dep generation with gcc -MMD?”
  1. Nguyen Thai Ngoc DuyNov 18, 2011
  2. Jonathan NiederNov 18, 2011
  3. Nguyen Thai Ngoc DuyNov 18, 2011
  4. Miles BaderNov 18, 2011
  5. Nguyen Thai Ngoc DuyNov 18, 2011
  6. Nguyen Thai Ngoc DuyNov 18, 2011
  7. Samuel BronsonNov 18, 2011
  8. Jonathan NiederNov 18, 2011
  9. Andreas SchwabNov 18, 2011
  10. Nguyen Thai Ngoc DuyNov 19, 2011
  11. Makefile: add option to disable automatic dependency generationJonathan Nieder, Nov 18, 2011
  12. Jonathan NiederNov 18, 2011
  13. Junio C HamanoNov 18, 2011
  14. Jonathan NiederNov 18, 2011
  15. Makefile: add option to disable automatic dependency generationJonathan Nieder, Nov 18, 2011
  16. Makefile: add missing header file dependenciesJonathan Nieder, Nov 18, 2011
  17. Nguyen Thai Ngoc DuyNov 18, 2011
  18. Makefile: explicitly set target name for autogenerated dependenciesJonathan Nieder, Nov 18, 2011
  19. Nguyen Thai Ngoc DuyNov 19, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.