Re: Bug in git-verify-pack or in its documentation?

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 16, 2015, 10:13 UTC
Message-ID: <CACsJy8AXvYCje0-smbNdfGtjsdYieKyxxiHCGf32Jpi3seDrvA@mail.gmail.com>
In-Reply-To: <20150316080558.GA30234@glandium.org>

On Mon, Mar 16, 2015 at 3:05 PM, Mike Hommey <mh@glandium.org> wrote:

Show 10 quoted lines

> Hi,
>
> git-verify-pack's man page says the following about --stat-only:
>
>    Do not verify the pack contents; only show the histogram of delta
>    chain length. With --verbose, list of objects is also shown.
>
> However, there is no difference of output between --verbose and
> --verbose --stat-only (and in fact, looking at the code, only one of
> them has an effect, --stat-only having precedence).

There is. very-pack --verbose would show a lot of "<sha-1> <type> <"random" numbers>" lines before the histogram while --stat-only (with or without --verbose) would only show the histogram.

Show 5 quoted lines

> The text above also implies that this should only display the stats
> without doing any sha1 validation, but afaict from a quick glance at
> the index-pack code, they are always performed.
>
> Is it an implementation problem or a documentation problem?

I think code and document start to divert from 3de89c9 (verify-pack: use index-pack --verify - 2011-06-03). The conversion to using index-pack implies heavier verification anyway (all objects must be hashed, no way around it), so I'd say it's documentation problem. The other way would be revert some patches in verify-pack.c and add more maintenance burden for this command.

-- 
Duy