git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] receive-pack: optionally deny case clone refs

From
Duy Nguyen <pclouds@gmail.com>
Date
Jun 6, 2014, 01:37 UTC
Message-ID
<CACsJy8ALeYR1+5ox2GE2Rz3TRM5wqd9fxSCAnHoabo9fmuSdXQ@mail.gmail.com>
In-Reply-To
<1402015954-5320-1-git-send-email-dturner@twitter.com>
On Fri, Jun 6, 2014 at 7:52 AM, David Turner <dturner@twopensource.com> wrote:
> Create the option receive.denycaseclonerefs, which checks pushed
> refs to ensure that they are not case clones of an existing
> ref.  This setting is turned on by default if core.ignorecase is
> set, but not otherwise.

Just thinking out loud as I haven't had time to read this patch carefully, but I wonder if there's a potential performance problem with ref_is_denied_case_clone(). What if the receiver repo has 60k refs? Should we use name-hash (or a variant of it)? What if the sender pushes 60k refs in one go, will ref_is_denied_case_clone check against existing refs only, or it will cover more and more refs from the 60k input?

-- 
Duy
Previous: David TurnerNext: David Turner
Message 2 of 3 in “receive-pack: optionally deny case clone refs”
  1. receive-pack: optionally deny case clone refsDavid Turner, Jun 6, 2014
  2. Duy NguyenJun 6, 2014
  3. David TurnerJun 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.